fix: Remove dependency of lodash isString (#1066)

SBoudrias · Nov 17, 2021 · 4769839 · 4769839
1 parent e5bb189
commit 4769839
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/inquirer/lib/objects/choice.js b/packages/inquirer/lib/objects/choice.js
@@ -1,6 +1,5 @@
 'use strict';
 const _ = {
-  isString: require('lodash/isString'),
   isNumber: require('lodash/isNumber'),
   extend: require('lodash/extend'),
   isFunction: require('lodash/isFunction'),
@@ -22,7 +21,7 @@ module.exports = class Choice {
       return val;
     }
 
-    if (_.isString(val) || _.isNumber(val)) {
+    if (typeof val === 'string' || _.isNumber(val)) {
       this.name = String(val);
       this.value = val;
       this.short = String(val);

diff --git a/packages/inquirer/lib/prompts/checkbox.js b/packages/inquirer/lib/prompts/checkbox.js
@@ -5,7 +5,6 @@
 
 const _ = {
   map: require('lodash/map'),
-  isString: require('lodash/isString'),
 };
 const chalk = require('chalk');
 const cliCursor = require('cli-cursor');
@@ -248,7 +247,9 @@ function renderChoices(choices, pointer) {
     if (choice.disabled) {
       separatorOffset++;
       output += ' - ' + choice.name;
-      output += ' (' + (_.isString(choice.disabled) ? choice.disabled : 'Disabled') + ')';
+      output += ` (${
+        typeof choice.disabled === 'string' ? choice.disabled : 'Disabled'
+      })`;
     } else {
       const line = getCheckbox(choice.checked) + ' ' + choice.name;
       if (i - separatorOffset === pointer) {

diff --git a/packages/inquirer/lib/prompts/expand.js b/packages/inquirer/lib/prompts/expand.js
@@ -5,7 +5,6 @@
 
 const _ = {
   uniq: require('lodash/uniq'),
-  isString: require('lodash/isString'),
   isNumber: require('lodash/isNumber'),
   findIndex: require('lodash/findIndex'),
 };
@@ -236,7 +235,7 @@ class ExpandPrompt extends Base {
     let defIndex = choices.realLength - 1;
     if (_.isNumber(defaultChoice) && this.opt.choices.getChoice(defaultChoice)) {
       defIndex = defaultChoice;
-    } else if (_.isString(defaultChoice)) {
+    } else if (typeof defaultChoice === 'string') {
       const index = _.findIndex(
         choices.realChoices,
         ({ value }) => value === defaultChoice

diff --git a/packages/inquirer/lib/prompts/list.js b/packages/inquirer/lib/prompts/list.js
@@ -6,7 +6,6 @@
 const _ = {
   isNumber: require('lodash/isNumber'),
   findIndex: require('lodash/findIndex'),
-  isString: require('lodash/isString'),
 };
 const chalk = require('chalk');
 const figures = require('figures');
@@ -194,7 +193,9 @@ function listRender(choices, pointer) {
     if (choice.disabled) {
       separatorOffset++;
       output += '  - ' + choice.name;
-      output += ' (' + (_.isString(choice.disabled) ? choice.disabled : 'Disabled') + ')';
+      output += ` (${
+        typeof choice.disabled === 'string' ? choice.disabled : 'Disabled'
+      })`;
       output += '\n';
       return;
     }