Bump diff from 4.0.2 to 5.0.0 (#191)

* Bump diff from 4.0.2 to 5.0.0

Bumps [diff](https://github.com/kpdecker/jsdiff) from 4.0.2 to 5.0.0.
- [Release notes](https://github.com/kpdecker/jsdiff/releases)
- [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md)
- [Commits](kpdecker/jsdiff@v4.0.2...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

* fixed tests, the changes to the expected test files' content is minimal
and there is no best solution.

Breaking change is:
kpdecker/jsdiff#217

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tobias Sorn <tobias.sorn@sap.com>

package.json

@@ -97,7 +97,7 @@
     "url": "git@github.com:SAP/ui5-migration.git"
   },
   "dependencies": {
-    "diff": "^4.0.2",
+    "diff": "^5.0.0",
     "esprima": "^4.0.1",
     "globals": "^13.13.0",
     "graceful-fs": "^4.2.9",

src/util/whitespace/DiffStringOptimizeStrategy.ts

@@ -58,12 +58,12 @@ export class DiffStringOptimizeStrategy implements StringOptimizeStrategy {
 		aResult.forEach(oChange => {
 			iIndex = sIgnoreWhitespaceChanges.length;
 			if (oChange.removed === undefined && oChange.added === undefined) {
+				// neither added nor removed
+				// safely apply the changes
 				sIgnoreWhitespaceChanges += oChange.value;
 			} else if (oChange.added && oChange.removed === undefined) {
-				// add non-whitespace changes
-				if (!StringWhitespaceUtils.isWhitespace(oChange.value)) {
-					sIgnoreWhitespaceChanges += oChange.value;
-				} else {
+				// skip whitespaces
+				if (StringWhitespaceUtils.isWhitespace(oChange.value)) {
 					if (this.reporter) {
 						this.reporter.collect(
 							"DiffStringOptimizeStrategy.skipped",
@@ -76,6 +76,9 @@ export class DiffStringOptimizeStrategy implements StringOptimizeStrategy {
 							)}`
 						);
 					}
+				} else {
+					// add non-whitespace changes
+					sIgnoreWhitespaceChanges += oChange.value;
 				}
 			} else if (oChange.removed && oChange.added === undefined) {
 				// add whitespace change if it was removed