Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-1035) - A11y use native buttons for button-like elements #18850

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: (CXSPA-1035) - A11y use native buttons for button-like elements #18850

merged 1 commit into from
May 31, 2024

Conversation

sdrozdsap
Copy link
Contributor

No description provided.

@sdrozdsap sdrozdsap requested review from a team as code owners May 15, 2024 09:02
@github-actions github-actions bot marked this pull request as draft May 15, 2024 09:02
@sdrozdsap sdrozdsap marked this pull request as ready for review May 15, 2024 09:04
@github-actions github-actions bot marked this pull request as draft May 15, 2024 09:18
@cypress Cypress
Copy link

cypress bot commented May 15, 2024 •
edited

3 flaky tests on run #43802 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge bfc0dfd into 934d005...
Project: spartacus Commit: 5b022fcb06 ℹ️
Status: Passed Duration: 04:33 💡
Started: May 24, 2024 12:54 PM Ended: May 24, 2024 12:59 PM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18850 ↗︎

@sdrozdsap sdrozdsap marked this pull request as ready for review May 15, 2024 09:28
steinsebastian
steinsebastian previously approved these changes May 15, 2024
View reviewed changes
Zeyber
Zeyber previously approved these changes May 16, 2024
View reviewed changes
@sdrozdsap sdrozdsap dismissed stale reviews from Zeyber and steinsebastian via a11f860 May 16, 2024 06:25
@github-actions github-actions bot marked this pull request as draft May 16, 2024 06:26
@sdrozdsap sdrozdsap marked this pull request as ready for review May 16, 2024 06:26
@developpeurweb
Copy link
Contributor

@sdrozdsap Can you please also update these "Cancel" buttons with the same solution. Thanks!

close account
update details
update pwd

@github-actions github-actions bot marked this pull request as draft May 24, 2024 12:44
@sdrozdsap
Copy link
Contributor Author

@developpeurweb Done!

@sdrozdsap sdrozdsap marked this pull request as ready for review May 24, 2024 12:45
Zeyber
Zeyber previously approved these changes May 27, 2024
View reviewed changes
developpeurweb
developpeurweb previously approved these changes May 29, 2024
View reviewed changes
@sdrozdsap sdrozdsap dismissed stale reviews from developpeurweb and Zeyber via f9d864f May 31, 2024 09:49
@github-actions github-actions bot marked this pull request as draft May 31, 2024 09:49
@sdrozdsap sdrozdsap marked this pull request as ready for review May 31, 2024 09:55
@sdrozdsap sdrozdsap merged commit 21b884d into develop May 31, 2024
28 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-1035 branch May 31, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@developpeurweb developpeurweb developpeurweb left review comments

@steinsebastian steinsebastian steinsebastian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdrozdsap @developpeurweb @Zeyber @steinsebastian