Feat: [ASM] Adding link to customer list for navigating to customer360 #18816
+116
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/CXSPA-6858
scarai-sap
changed the title
4 flaky tests on run #43742 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Assisted Service Module > Customer Support Agent - Emulation > should checkout as customer |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18816 ↗︎
scarai-sap
changed the title
niehuayang
reviewed
May 14, 2024
| ); | ||
|
|
||
| this.subscription.add( | ||
| this.launchDialogService?.dialogClose |
There was a problem hiding this comment.
copy from below code, I guess yes, we can remove the ?
createCustomer(): void {
this.launchDialogService?.openDialogAndSubscribe(
LAUNCH_CALLER.ASM_CREATE_CUSTOMER_FORM,
this.addNewCustomerLink
);
}
There was a problem hiding this comment.
yes, we can also remove it.
I guess that we fristly add 'launchDialogService' to custructor with a breakchange, then to haddle the break change, we had to difine it as
constructor(
............
protected launchDialogService**?**: LaunchDialogService
) {}
and in the major version, we don't remove all redundant code.
feature-libs/asm/components/asm-main-ui/asm-main-ui.component.ts
Outdated
Show resolved
Hide resolved
i53577
previously approved these changes
May 14, 2024
niehuayang
previously approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.tools.sap/browse/CXSPA-6858