New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate the openapi-generator from oclif to yargs #1661
Merged
Merged
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
84248c0
Add yargs options
6827a6d
Fix types
d25a1c1
Fix typo bug in parseGeneratorOptions
306dd85
Fix config handling
8429f51
Merge branch 'main' into yargs-openapi-generator
8422d4e
Remove oclif and cli-ux
0e9e85e
Improve types
d3079dc
Replace parsedGeneratorOptions
a8e37a7
Merge branch 'main' into yargs-openapi-generator
da3e328
Fix tests
e071b06
Fix tests
63be9dd
Revert change to cli option 'include'
a87c626
Merge branch 'main' into yargs-openapi-generator
9189da7
Apply coerce if not using argv
36f8b3d
Differentiate between GeneratorOpts and ParsedOpts
be5c793
Fix tests (hopefully)
84e05a5
Revert change to options in generate-test-services
0bc286d
Debug integration tests
3cd379d
Merge branch 'main' into yargs-openapi-generator
9006e4d
Merge branch 'main' into yargs-openapi-generator
c32dc85
Add shebang
7aba91e
Fix tests
5b00538
Fix typos
94edc9a
Merge branch 'main' into yargs-openapi-generator
eda744d
Fix integration tests
2345779
Fix tests
98afcdd
Merge branch 'main' into yargs-openapi-generator
36f87c5
Use stricter version for @sap packages
5f2f238
Generate readme
de69310
Merge branch 'main' into yargs-openapi-generator
400cb64
Add note to changelog
7b80638
Use node 14 instead of 12 in GHActions
b9c9568
Revert node14 to node12
5461604
Move index.ts to cli.ts
b8df407
Rename flags.ts to options.ts
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node 12 is in maintenance mode until Apr2022. Therefore I assume we should be okay to test with node 14 instead. This change is required to use fs/promises which are used in the generate-readme.ts script below. If this is a problem, we could replace fs/promises with utils.promisify or fs-extra instead. Just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was planned anyways for 2.0, right? Please document this in the new changelog-v2.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, maybe next time this could be a separate PR (for easier reverting if something goes wrong).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We planned to migrate to ES19 as it is supported by node14 and above. Since the readme script is not customer facing, this still means that we are node12 compatible but are no longer testing it explicitly...
You got a point with this being a separate PR. Should I do this already? I don't expect too much effort for splitting.