Make the gem compatible with --enable-frozen-string-literal
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has been available for a very long time in Ruby, and will probably become the default in the semi-near future. Ref: https://bugs.ruby-lang.org/issues/20205
|
@casperisfine it's better to just add the magic comment to the top of every file. I think Rubocop autocorrect can do it. |
|
@johnnyshields I can do that if you prefer, that's no problem. |
|
@pitbulk are you ok with it? |
|
Hum, looks like So I may need to use |
|
I think we are overdue to drop Ruby less than 2.3, so can probably keep this PR as-is. Also should be a single blank line after the magic comment. |
NB: On Ruby 2.5 and 2.6, string literals with interpolation are frozen too, which was changed in 2.7, hence why this commit makes some changes to some code.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has been available for a very long time in Ruby, and will probably become the default in the semi-near future.
Ref: https://bugs.ruby-lang.org/issues/20205