Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow process_response and process_slo to raise exceptions #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwlogel
Copy link

@rwlogel rwlogel commented Jul 25, 2019

No description provided.

@pitbulk
Copy link
Contributor

pitbulk commented Jul 26, 2019

Why raise exceptions instead get them on the errors var and raise after the process method ends if you want?

@rwlogel
Copy link
Author

rwlogel commented Jul 26, 2019

Thank you, I didn't realize that the error message was stored into the error reason. That said it is nice to be able to see the actual exception so you know exactly what line it was raised on in the validation code. This is helpful in determining exactly what rule was broken and if it is possible to disable that check.

Currently the raise_exceptions is a useful feature that isn't really accessible to the caller unless they make their own response object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants