news-viewer project finished. code review start #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanKor
commented
Nov 16, 2020
|
|
||
| import React from 'react' | ||
| import {Route} from 'react-router-dom' | ||
| import NewsPage from './components/NewsPage' |
There was a problem hiding this comment.
컴포넌트 파일에서 만들어진 News page 값을 React-Router로 연결해 값을 받는다.
| import styled from 'styled-components' | ||
| import {NavLink} from 'react-router-dom' | ||
|
|
||
| const categories = [ |
There was a problem hiding this comment.
NavLink (React Router) 에서 상단 네브바를 구성할 리터럴 객체 작업
| import Categories from '../components/Categories' | ||
| import NewsList from '../components/NewsList' | ||
|
|
||
| const NewsPage = ({match}) =>{ |
There was a problem hiding this comment.
{match} 속성은 React-Router를 활용하면 가져오는 속성으로 url의 param을 가져온다.
| @@ -3,11 +3,12 @@ import ReactDOM from 'react-dom'; | |||
| import './index.css'; | |||
| import App from './App'; | |||
| import reportWebVitals from './reportWebVitals'; | |||
| import {BrowserRouter} from 'react-router-dom' | |||
| @@ -0,0 +1,24 @@ | |||
| import {useState, useEffect} from 'react' | |||
|
|
|||
| export default function usePromise(promiseCreator, deps){ | |||
There was a problem hiding this comment.
news api 정보의 대기, 로딩 완료, 실패를 가져오게끔 별도의 컴포넌트를 구성해 작업하는 파일
|
작업하면서 발생했던 에러 정리 문제점
별도로 설정 값에서 수동 작업했던 코드는 없었는데, 구글링을 통해 해당 에러 이유를 찾아보니 버전의 충돌이 발생한 것 같았다.
위와 같이 yarn 설정을 제거하고 다시 설치했더니 정상 작동했다. 끝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
벨로퍼트 News-API 뷰어 프로젝트 마무리
주안점
상태 관리를 위해 UseEffect를 굉장히 잘 활용하는 점
파일을 나눠서 코드 관리를 좀 더 용이하게 진행하는 점
Todo App 보다 더 다양한 모듈을 활용하는 점