Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: fix undefined "generator.filename" option #101

Merged
merged 2 commits into from Nov 4, 2022

Conversation

anatoo
Copy link
Contributor

@anatoo anatoo commented Jul 19, 2022

fixes #100

@github-actions
Copy link

This PR has been automatically marked stale because it it received no activity for 60 days. If you wish to keep this open, please leave a comment. Thanks.

@github-actions github-actions bot added the Stale label Sep 18, 2022
@github-actions
Copy link

This PR has been automatically closed because it received no activity for 60 days. If you think this was closed by accident, please leave a comment. Thanks.

@puku0x
Copy link

puku0x commented Oct 22, 2022

@RyanClementsHax Could you reopen and review this PR, please?

With nrwl/nx#12276 and the fallbacks in this PR, the issue #100 should be solved👍

@mandarini
Copy link

Hi there @RyanClementsHax ! Can you please take a look at this, and please reopen? Let me know if you need any help reviewing! It would really help with the Nx integration!

@RyanClementsHax RyanClementsHax merged commit 4acc839 into RyanClementsHax:main Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

🎉 This PR is included in version 1.6.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mandarini
Copy link

Thank you SO much @RyanClementsHax !!!! :D

@RyanClementsHax
Copy link
Owner

No prob thanks for helping to test :)

@daves28
Copy link

daves28 commented Jun 26, 2023

The issue that this fixed is currently present in the @storybook/nextjs framework. I can make a PR to copy this change over to that as well.

daves28 added a commit to daves28/storybook that referenced this pull request Jun 26, 2023
This issue RyanClementsHax/storybook-addon-next#100 involving storybook-addon-next and the nx plugin @nx/react/plugin/storybook was resolved  RyanClementsHax/storybook-addon-next#101, but that fix didn't make it to this equivalent file here in @storybook/nextjs, making that issue still present when using Storybook 7 and @storybook/nextjs as the framework.
@RyanClementsHax
Copy link
Owner

I'd be happy to review any PRs :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with @nrwl/react/plugins/storybook addon
5 participants