New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements 6 os/posix constants missing for macos #4110
Conversation
Thank you! libc is very responsive and they have frequent release schedules. Once you submit a proper patch, it will be available in 2 weeks in high chance. |
vm/src/stdlib/posix.rs
Outdated
const O_EVTONLY: i32 = 0x8000; | ||
#[cfg(target_os = "macos")] | ||
#[pyattr] | ||
const O_FSYNC: i32 = 0x80; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vm/src/stdlib/posix.rs
Outdated
const O_FSYNC: i32 = 0x80; | ||
#[cfg(target_os = "macos")] | ||
#[pyattr] | ||
const O_SYMLINK: i32 = 0x200000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libc update: rust-lang/libc#2886 |
Thanks for submitting the PR to libc! I saw your reply last night before I went to bed and was going to do that myself in the morning -- I should've let you know last night, sorry. For the 2 requested changes, did you just want me to go ahead and use libc for the 2 it has already? (I had purposely done them all as constants for consistency. But I can fix those 2. Just confirming that's what you meant.) |
I want to keep Python-independent things as much as possible outside of RustPython. To be honest, if you are not planning to work on another issue depending on this PR, I want to make everything referring libc before merging - unless they take too long time. |
Yeah, that makes sense. Let's leave it open until libc has them all. (No rush on my side. Just wanted to do an easy first PR on the project.) |
Thank you for understanding! I will notify you when it done. |
The PR is merged. It will be released in the next version (probably 0.2.133) |
@ecpost libc is updated! it took a lot longer time than expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Implements 6 os/posix constants missing for macos:
I suppose it would be better to send a PR to libc to have these added (and I'm happy to do that as well), rather than hard-coding them here. But I don't know how long it would take for that change (in whatever libc version) to make its way back here. So I did them as constants that can be switched to libc re-exports if/when they're available in the future.
Ref: #1175