Update libc deps to 0.2.95 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, makes sense. It was specifically set to v0.2.95 for those those constants, and bumped down by mistake since it wasn't properly tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788. I'm not sure if all targets need to be updated or just
aarch64(probably justaarch64). If so I can remove bumping the version in other targetsHWCAP_* consts for aarch64 were added to libc in rust-lang/libc#2172 and released in v0.2.95
It looks like these constants were imported into cpufeatures in #456 and the libc version was bumped to 0.2.95 accordingly. But then in #732 libc version was bumped down. I think the minimum libc version should be bumped back up to 0.2.95 to include these constants