elliptic-curve: revised LinearCombination trait
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `LinearCombination` to be impl'd on the `ProjectivePoint` type for a given curve, rather than the curve ZST. This better fits the trait-based structure used by the `group` crate, and also makes sense as `ProjectivePoint` is the return type, so it's almost certain to be in scope (as opposed to importing a curve ZST to do the operation) This is technically a breaking change as the `LinearCombination` trait was just released an hour ago in v0.11.4, but given that it's unlikely anyone is using it yet, so it can probably be safely yanked and the updated version included in a new release.
Merged
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Dec 4, 2021
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Dec 4, 2021
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Dec 4, 2021
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Dec 4, 2021
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LinearCombinationto be impl'd on theProjectivePointtype for a given curve, rather than the curve ZST.This better fits the trait-based structure used by the
groupcrate, and also makes sense asProjectivePointis the return type, so it's almost certain to be in scope (as opposed to importing a curve ZST to do the operation)This is technically a breaking change as the
LinearCombinationtrait was just released an hour ago in v0.11.4, but given that it's unlikely anyone is using it yet, so it can probably be safely yanked and the updated version included in a new release.