Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cipher: revert SeekNum::from_block_byte change #439

Merged
merged 1 commit into from Dec 30, 2020

Commits on Dec 30, 2020

  1. cipher: revert SeekNum::from_block_byte change

    This reverts the implementation of `SeekNum::from_block_byte` which was
    merged as part of #435.
    
    I'm not exactly sure what the issue is and it's somewhat difficult to
    debug in that it's code that involves both generics and macros causing
    an error as part of any failure in a long chain of checked arithmetic,
    which I'm trying to debug from the context of a concrete stream cipher
    impl (both `chacha20` and `salsa20`) where it's operating over a generic
    type.
    
    The error manifests as `OverflowError`:
    
    RustCrypto/stream-ciphers#205 (comment)
    
    This commit reverts to the previous implementation, which is at least
    much simpler.
    tarcieri committed Dec 30, 2020
    Copy the full SHA
    c8242ce View commit details
    Browse the repository at this point in the history