New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cipher: integrate block-modes
#394
Conversation
pub type Block<M> = GenericArray<u8, <M as BlockModeCore>::BlockSize>; | ||
|
||
/// Core trait for a block cipher mode of operation. | ||
pub trait BlockModeCore { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: why not just BlockMode
?
@@ -14,9 +14,12 @@ categories = ["cryptography", "no-std"] | |||
[dependencies] | |||
generic-array = "0.14" | |||
blobby = { version = "0.3", optional = true } | |||
block-padding = { verstion = "0.2", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: verstion
block-padding = { verstion = "0.2", optional = true } | |
block-padding = { version = "0.2", optional = true } |
I went ahead and landed most of this PR except for the WIP It should hopefully be easy to rebase or cherry-pick the remaining work. |
A number of changes for
cipher v0.3
.Edit: many of these changes were already merged in #435 -@tarcieri