digest: add block-level API #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
digest_core
branch
from
2e24c12
to
b207e71
Compare
tarcieri
approved these changes
Dec 4, 2020
|
What's the status of this? It seems like it's the only major change holding back releases of digest and blake2 (RustCrypto/hashes#198). |
|
@jplatte |
newpavlov
force-pushed
the
digest_core
branch
from
42d0a04
to
9e0d4e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes block-level API and adds a wrapper type which implements the higher-level traits. It allows to remove some of boilerplate from the implementation crates, plus we no longer need the macro for implementing
io::Read. Also it will allow a more efficient HMAC implementation.Additionally PR removes the variable length API in favor of making type generic over output length as suggested in #262.