fix: missing_debug_implementations
#1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
missing_debug_implementations
branch
2 times, most recently
from
b580482
to
54a3024
Compare
newpavlov
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Similarly to RustCrypto/block-modes/pull/46, you should not derive Debug for types which contain sensitive information.
| @@ -250,9 +250,9 @@ pub trait BlockDecrypt: BlockSizeUser { | |||
| #[cfg(feature = "block-padding")] | |||
| #[cfg_attr(docsrs, doc(cfg(feature = "block-padding")))] | |||
| #[inline] | |||
| fn decrypt_padded_inout<'inp, 'out, P: Padding<Self::BlockSize>>( | |||
| fn decrypt_padded_inout<'out, P: Padding<Self::BlockSize>>( | |||
There was a problem hiding this comment.
Technically, removing lifetime argument is a breaking change.
There was a problem hiding this comment.
Okay, do I need to take any action for this?
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
I don't know which implementations should be changed. Could you suggest these specific changes or note the implementations to change. |
JonathanWoollett-Light
force-pushed
the
missing_debug_implementations
branch
from
54a3024
to
a04b302
Compare
12 tasks
|
This PR got outdated, so I will close it in favor of the tracking issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
missing_debug_implementationsto warn and adds missingstd::fmt::Debugimplementations.When tracing/logging/debugging a program it is common to debug print inputs and outputs of function, to do this generally dependencies need to offer
std::fmt::Debugimplementations.I won't repeat what is written under
missing_debug_implementationswhich gives some more explanation.