Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement AsyncStreamCipher buffering #964

Closed
cfal opened this issue Mar 13, 2022 · 3 comments
Closed

re-implement AsyncStreamCipher buffering #964

cfal opened this issue Mar 13, 2022 · 3 comments
Labels
cipher Block and stream cipher crate

Comments

@cfal
Copy link

cfal commented Mar 13, 2022

AsyncStreamCipher used to take an &mut self parameter for its encrypt and decrypt functions that would save the iv from the previous block and allow for cfb mode encryption/decryption in a streaming manner: https://docs.rs/cfb-mode/0.7.1/src/cfb_mode/lib.rs.html#79-170

with cfb-mode 0.8.0, encrypt/decrypt now consumes self and no longer supports this.

it would be very helpful for users of cfb-mode 0.7.1 to be able to upgrade to 0.8.0 without having to re-implement this functionality themselves.

thank you!

@saiintbrisson
Copy link

I strongly sympathize with this issue as a user of the cfb8 crate. I'm willing to work on a solution, but I'm unsure of what is preferred. Should the functions within AsyncStreamCipher just change back to &mut self (probably a breaking change)? Should a new trait be created?

@tarcieri
Copy link
Member

There have been enough reports of issues I’d be in favor of reverting the change in cipher v0.5

@newpavlov newpavlov added the cipher Block and stream cipher crate label Sep 15, 2022
@newpavlov
Copy link
Member

RustCrypto/block-modes#17 is merged and released, so I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cipher Block and stream cipher crate
Projects
None yet
Development

No branches or pull requests

4 participants