-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate IV exposing for save/restore APIs #5
Comments
Sounds good to me. @newpavlov, what do you think? |
One detail is that the |
Unifying it into a single trait sounds good to me and follows the general course of what @newpavlov has been working on in the |
Sounds good to me as well, but, as you've noticed, it's blocked on introduction of a block-level trait for stream ciphers. Right now we have only slice-based traits which handle buffering internally, thus the |
I don't understand this part? The whole point is to use the byte-based interface. |
I should have emphasized on the fact that we currently need this for CFB and OFB (for CTR, |
I think #2 should resolve this issue. For performance reasons we store encrypted IV, so implementation of the Also note that neither |
did this used to be supported? |
@cfal |
@newpavlov thank you! created RustCrypto/traits#964 |
Hello folks, would you accept a PR similar to block-ciphers/pull/227 as suggested by @newpavlov, allowing to serialize ciphers and continue operation later? Note that even without the exposure, the cryptor can recover the internal IV state at any moment, but this would require additional caching (one full ciphertext block for CFB, and one ciphertext block + one plaintext block + one xor for OFB). Perhaps we could implement the same
IvState
trait.Regards
cc. @jethrogb
The text was updated successfully, but these errors were encountered: