optimization: reusing AEAD Cipher instance #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 10, 2022
tarcieri
requested changes
Mar 10, 2022
Preventing the Key being copied every time when calling encrypt_* and decrypt_*
tarcieri
approved these changes
Mar 11, 2022
|
One more thing: |
|
@zonyitoo The next release of the elliptic curve crate dependencies will upgrade to If you bump them now, you'll need to bump them all to prerelease versions. |
|
Ah, then I will stop right here. Will you consider making a new release with these changes? @tarcieri |
|
Sure |
|
Ah.. May I ask when will you publish it to crates.io? |
|
Currently working on some other things, but in the next day or so |
zonyitoo
added a commit
to shadowsocks/shadowsocks-crypto
that referenced
this pull request
Mar 11, 2022
- Slightly performance improvement - RustCrypto/ring-compat#79
|
Ah @tarcieri , sorry to disturb, would you make a release to crates.io today or tomorrow? |
Merged
zonyitoo
added a commit
to shadowsocks/shadowsocks-rust
that referenced
this pull request
Mar 13, 2022
- RustCrypto/ring-compat#79 - Upgraded other dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation will require a copy operation for key in every call of
encrypt_*anddecrypt_*functions.