New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimization: reusing AEAD Cipher instance #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One small issue but otherwise this looks good
Preventing the Key being copied every time when calling encrypt_* and decrypt_*
One more thing: |
@zonyitoo The next release of the elliptic curve crate dependencies will upgrade to If you bump them now, you'll need to bump them all to prerelease versions. |
Ah, then I will stop right here. Will you consider making a new release with these changes? @tarcieri |
Sure |
Ah.. May I ask when will you publish it to crates.io? |
Currently working on some other things, but in the next day or so |
- Slightly performance improvement - RustCrypto/ring-compat#79
Ah @tarcieri , sorry to disturb, would you make a release to crates.io today or tomorrow? |
- RustCrypto/ring-compat#79 - Upgraded other dependencies
The current implementation will require a copy operation for key in every call of
encrypt_*
anddecrypt_*
functions.