password-auth: replace VerifyError with Error enum
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VerifyError` was previously the return type for the `verify_password` function which has two distinct error cases: - Password hash failed to parse - Password is invalid This commit replaces `VerifyError` with an `Error` enum which captures both cases. It leverages the `ParseError` type which was added in #428.
tarcieri
force-pushed
the
password-auth/replace-verify-error-with-error-enum
branch
from
e37b5e0
to
c32f3eb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerifyErrorwas previously the return type for theverify_passwordfunction which has two distinct error cases:This commit replaces
VerifyErrorwith anErrorenum which captures both cases.It leverages the
ParseErrortype which was added in #428.