Enable alloc feature of password-hash if enabled for argon2/balloon-hash #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the `password-hash/alloc` feature if the `argon2/alloc` or `balloon-hash/alloc` features are enabled. Prior to this commit, if a user adds argon2 as a dependency with the `alloc` feature enabled, but not the `std` feature (which is the case with the default feature set), then the `alloc` feature of `password-hash` is not enabled. This means that feature-gated types such as `PasswordHashString` are not available in the `password-hash` re-export, so users wishing to use these types will have to add `password-hash` as a separate dependency.
|
Looks good, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR enables the
password-hash/allocfeature if theargon2/allocorballoon-hash/allocfeatures are enabled.Prior to this PR, if a user adds argon2 as a dependency with the
allocfeature enabled, but not thestdfeature (which is the case with the default feature set), then theallocfeature ofpassword-hashis not enabled. This means that feature-gated types such asPasswordHashStringare not available in thepassword-hashre-export, so users wishing to use these types will have to addpassword-hashas a separate dependency.Thanks! :)