Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate Algorithm::as_str returning static str #416

Merged
merged 1 commit into from
May 20, 2023
Merged

Annotate Algorithm::as_str returning static str #416

merged 1 commit into from
May 20, 2023

Conversation

FirelightFlagboy
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy commented May 20, 2023 •
edited

Previously Algorithm::as_str used no lifetime specifier on the returned as_str, so the returned value inherited the lifetime of &self.

But the returned value are static value and could use the lifetime 'static instead.

@tarcieri tarcieri merged commit 1f483b3 into RustCrypto:master May 20, 2023
13 checks passed
@tarcieri
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FirelightFlagboy @tarcieri