Implement SerializableState for hashes #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rpiasetskyi Edit: The github UI is a bit confusing. I tried my best to keep your authorship, and I think individual commits should reflect that, but the github UI only lists me. |
baloo
force-pushed
the
baloo/serialize-state/rebase
branch
2 times, most recently
from
ab24678
to
375bdc1
Compare
baloo
force-pushed
the
baloo/serialize-state/rebase
branch
from
375bdc1
to
fce1d94
Compare
baloo
commented
Mar 18, 2024
baloo
force-pushed
the
baloo/serialize-state/rebase
branch
from
6f1cd19
to
a31cc1f
Compare
|
This PR solves the issue with using Thanks for your work @baloo 🙏 ! |
baloo
force-pushed
the
baloo/serialize-state/rebase
branch
from
a31cc1f
to
e7f742b
Compare
tarcieri
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #385 on master.
RustCrypto/traits#1369 introduced a
SerializableStatetrait to serialize the hasher. This implements it for each of the hashers we have.This depends on:
hash_serialization_testmacro traits#1537Support all array sizes up tohybrid-arrayU512hybrid-array#67v0.2.0-rc.8