Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIPEMD-256 implementation #278

Merged
merged 1 commit into from Jul 19, 2021
Merged

Conversation

gavadinov
Copy link
Contributor

Partially addresses #1

A RIPEMD-256 implementation based on the existing RIPEMD-320 implementation and https://android.googlesource.com/kernel/common/+/07e6124a1a46/crypto/rmd256.c.

The test values come from - https://homes.esat.kuleuven.be/~bosselae/ripemd160.html

@gavadinov gavadinov mentioned this pull request May 18, 2021
18 tasks
@tarcieri
Copy link
Member

@gavadinov great! I'll take a look when I have some time to review

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavadinov looks good!

I see you've already published the crate. Would you still like to upstream it here?

@gavadinov
Copy link
Contributor Author

hey @tarcieri, thank you for the review. Yeah I had to publish it because I needed to use it. I would be happy to move it here and to change the ownership of the crate on crates.io.

@tarcieri
Copy link
Member

@gavadinov fantastic. Does the code in this PR reflect what's published in the crate?

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good (although I did only a cursory review), so think we can merge and publish it. But note that later we probably will merge the 3 ripemd crates into a single ripemd crate.

@gavadinov
Copy link
Contributor Author

@gavadinov fantastic. Does the code in this PR reflect what's published in the crate?

Yep it is the same. Here is the original - https://github.com/gavadinov/ripemd256

But note that later we probably will merge the 3 ripemd crates into a single ripemd crate.

Yeah that makes sense. There is quite a lot of duplication between the crates.

@tarcieri tarcieri merged commit 677f59a into RustCrypto:master Jul 19, 2021
@tarcieri
Copy link
Member

@gavadinov cool, can you add us as owners of the ripemd256 crate?

@gavadinov
Copy link
Contributor Author

@gavadinov cool, can you add us as owners of the ripemd256 crate?

Done

Also I noticed a typo in the keywords 🙈 - #296

@tarcieri
Copy link
Member

Thank you!

@gavadinov gavadinov deleted the ripemd256 branch July 19, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants