Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit compilation error when compiled for Windows targets #79

Merged
merged 7 commits into from
May 7, 2024

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented May 5, 2024

We do not support MSVC targets and even compiling for GNU toolchain results in incorrect code, so raising explicit compilation errors for Windows targets looks like the best solution for these crates.

Closes #17
Closes #37
Closes #78

@newpavlov newpavlov requested a review from tarcieri May 5, 2024 14:07
@newpavlov newpavlov merged commit 8e80522 into master May 7, 2024
28 checks passed
@newpavlov newpavlov deleted the win_compile_error branch May 7, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Asm Hash is incorrect bench failed on Windows MSVC support
2 participants