feat(sha2): add aarch64 implementation for sha256 for the M1 chip #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this at least builds on my M1 Mac Mini. Seems like it might be good to have some basic smoke tests in these repos. |
|
I have tested this with: RustCrypto/hashes#261 which patches this branch in and enables the usage of |
tarcieri
approved these changes
May 4, 2021
There was a problem hiding this comment.
Per my end-to-end tests of RustCrypto/hashes#261 this appears to be working
Merged
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 5, 2021
This release includes support for Apple M1 CPUs: RustCrypto/asm-hashes#35
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
May 5, 2021
This release includes support for Apple M1 CPUs: RustCrypto/asm-hashes#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sha2 part of #28