Make padding module private
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only public type in the `padding` module is `PaddingScheme`, which is already re-exported from the toplevel. There is no rustdoc documentation at the top of the module, and therefore little value in having `PaddingScheme` available as both `rsa::PaddingScheme` and `rsa::padding::PaddingScheme`.
dignifiedquire
approved these changes
Jan 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only public type in the
paddingmodule isPaddingScheme, which is already re-exported from the toplevel.There is no rustdoc documentation at the top of the module, and therefore little value in having
PaddingSchemeavailable as bothrsa::PaddingSchemeandrsa::padding::PaddingScheme.