Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES SIV examples #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Christiaan676
Copy link

@Christiaan676 Christiaan676 commented Jun 6, 2023

This adds, AES-SIV examples and most importantly extra documentation that mentions the Rogway paper. The interface of the SIV module is based on this paper, and offers a more detail description of wat all the parameters are intended for.

@newpavlov newpavlov requested a review from tarcieri March 29, 2024 14:04
@newpavlov
Copy link
Member

This looks fine to me and I think we can merge it after fixing the conflict.

Copy link

@alt3r-3go alt3r-3go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the examples themselves, but hopefully suggested typo fixes are useful.

aes-siv/src/siv.rs Outdated Show resolved Hide resolved
aes-siv/src/siv.rs Outdated Show resolved Hide resolved
aes-siv/src/siv.rs Outdated Show resolved Hide resolved
aes-siv/src/siv.rs Outdated Show resolved Hide resolved
@Christiaan676
Copy link
Author

@newpavlov Merge conflicts have been solved.
@alt3r-3go Thanks for the review, all issues should be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants