Fix iOS bindings #17
Fix iOS bindings #17
Conversation
|
It seems like CI is broken for nightly. |
|
Thank you! This fixes my issues with building on OSX. |
| fn main() { | ||
| if let Ok(directory) = frameworks_path() { | ||
| build(&directory); | ||
| let (target, platform) = match std::env::var("TARGET") { |
There was a problem hiding this comment.
Isn't there a better way of doing this? All of this should be exposed via cfg, no?
There was a problem hiding this comment.
I believe cfg will return the building platform as this is build.rs, so here it would always be darwin. Unless I'm wrong. I can't check right now unfortunately.
| builder = builder.clang_arg(format!("-F/{}", frameworks_path)); | ||
| builder = builder | ||
| .clang_arg(format!("-F/{}", frameworks_path)) | ||
| .clang_arg("-isysroot") |
There was a problem hiding this comment.
Has this been tested on older versions of osx ?
There was a problem hiding this comment.
No, but I have no means to do it.
|
@Moxinilian thanks so much for this PR - super excited to hear you managed to get this going with iOS. I'd actually love to hear more about what you're using it for if you're free to share details on the project? Also, I'm guessing you were testing this on a version of macOS? May I ask which version of macOS it does work on? Also @Rhuagh if you did get a chance to test this and it built fine, which version of macOS? @mtak- which issue in particular were you running into prior to this PR? Also, if you don't mind me asking, which version of OSX and Xcode do you have on the system which is fixed by this PR? In summary, I'm just trying to check which versions of macOS are working so far :) If anyone's reading this that happens to be on 10.10 or prior, it would be great to hear whether or not this branch works for you! Otherwise I'll have access to a macbook air which might have 10.10 installed within a weeks time for testing. It would be nice to land this. |
|
I used latest High Sierra. |
|
@mitchmindtree I was trying to build ggez for iOS, (among other game libraries). Just to see what was currently possible with rust. I don't recall the particular issue, but it was definitely path related. So far nothing is really working, so I have no idea if this PR does more than let me build. I have a couple of notes on the PR that might help as well.
Possibly unnecessary flags for your project, but helped with getting other ios bindgen scripts to work
I am no longer using this as a dependency, hope that helps |
|
Ah, osx version is 10.13.6 Beta (17G47b) - High Sierra |
|
This code is fairly old, but I do remember dropping iPhoneSimulator because it was causing issues somewhere, but I don't remember where exactly. |
|
Not your sysroot argument. IIRC, at some point bindgen was adding an incorrect sysroot on osx when cross compiling for iOS. I can no longer find it in the bindgen master source. Sorry for the confusion |
This fixes the generation of bindings for iOS.
Huge thanks to @huhlig for the help to make this work.