Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually export package.json to support introspective tools #34

Merged

Conversation

rubensworks
Copy link
Collaborator

Tools such as Components.js and react-native require introspection of
the package.json file. Since the new export syntax does not imply
package.json resolution yet (nodejs/node#33460), this has to be exported
explicitly. Ideally, this would be something that is done implicitly by
Node.js, but this is something that is still being discussed at
nodejs/node#33460. So until then, this has to be added explictly to
avoid breaking other tooling.

Related to uuidjs/uuid#444

Tools such as Components.js and react-native require introspection of
the package.json file. Since the new export syntax does not imply
package.json resolution yet (nodejs/node#33460), this has to be exported
explicitly. Ideally, this would be something that is done implicitly by
Node.js, but this is something that is still being discussed at
nodejs/node#33460. So until then, this has to be added explictly to
avoid breaking other tooling.

Related to uuidjs/uuid#444
@RubenVerborgh RubenVerborgh self-assigned this Nov 3, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fe854a4 on rubensworks:fix/packagejsonexport into 0244961 on RubenVerborgh:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants