New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: markdown to custom components #90
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PostArticle will be re-implemented soon (this is left over from the legacy site)
- Requires further work need to use props.children for rendering example
m7kvqbe1
commented
Jun 26, 2019
@@ -0,0 +1,3 @@ | |||
.post-article { | |||
width: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary layout fix (hack). The post-article
component needs styling from the ground up.
m7kvqbe1
force-pushed
the
feature/markdown-to-custom-components
branch
2 times, most recently
from
June 26, 2019 14:16
057ddc0
to
904ad20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira issue:
https://rn-nelson.atlassian.net/browse/EN-688
Overview
Implement a pre-parser for the component library
README.md
files to convert MD into MDX.Reason
The
README.md
files need to stay as pure markdown, but in order to display them on the docs-site some markdown structures need to be converted to their corresponding docs-site JSX representation (presentational components).Work carried out
CodeHighlighter
&DataTable
)transformTableData
forDataTable
translator@babel/node
CLI)Screenshot
Developer notes
There is a known issue with Yarn workspaces and resolutions: yarnpkg/yarn#5039
This is currently blocking me from dealing with the audit error.
Potential solution: yarnpkg/yarn#6669 (comment)