Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Drawer): Migrate to styled-components #1862

Merged
merged 3 commits into from Jan 18, 2021

Conversation

m7kvqbe1
Copy link
Member

Related issue

Closes #1852

Overview

Migrate Drawer to styled-components.

Reason

Migrating all components.

@m7kvqbe1 m7kvqbe1 added Type: Enhancement New feature or request Package: react-component-library Package/code type labels Jan 14, 2021
@m7kvqbe1 m7kvqbe1 self-assigned this Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1862 (fabf5c0) into master (bf7b5f8) will decrease coverage by 5.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1862      +/-   ##
==========================================
- Coverage   98.08%   92.72%   -5.36%     
==========================================
  Files         275       16     -259     
  Lines        2349      165    -2184     
  Branches      612       39     -573     
==========================================
- Hits         2304      153    -2151     
+ Misses         45       12      -33     
Impacted Files Coverage Δ
.../src/components/NumberInput/EndAdornmentButton.tsx
...elNavigation/SidebarE/partials/StyledHeadTitle.tsx
...ry/src/components/Timeline/TimelineTodayMarker.tsx
...-component-library/src/components/Select/Input.tsx
...ponent-library/src/components/Tooltip/constants.ts
...ry/src/components/Dialog/partials/StyledDialog.tsx
...library/src/components/ButtonGroup/ButtonGroup.tsx
...onents/DismissibleBanner/partials/StyledFooter.tsx
.../src/components/Pagination/partials/StyledList.tsx
...t-component-library/src/components/Modal/Modal.tsx
... and 280 more

@m7kvqbe1 m7kvqbe1 force-pushed the refactor/drawer-styled-components branch from fabf5c0 to 6179fa6 Compare January 18, 2021 12:11
@m7kvqbe1 m7kvqbe1 changed the title [WIP] refactor(Drawer): Migrate to styled-components refactor(Drawer): Migrate to styled-components Jan 18, 2021
@m7kvqbe1 m7kvqbe1 marked this pull request as ready for review January 18, 2021 12:12
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2021

Code Climate has analyzed commit 6179fa6 and detected 0 issues on this pull request.

View more on Code Climate.

@m7kvqbe1
Copy link
Member Author

I've had to add skips to some tests - see the following issue: styled-components/jest-styled-components#335

Copy link
Collaborator

@thyhjwb6 thyhjwb6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7kvqbe1 m7kvqbe1 merged commit 7b6b648 into master Jan 18, 2021
@m7kvqbe1 m7kvqbe1 deleted the refactor/drawer-styled-components branch January 18, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-component-library Package/code type Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Drawer to styled-components
2 participants