-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small #11
base: master
Are you sure you want to change the base?
Small #11
Conversation
…folder in RestMain Author: Mukti <muktikrishnan94@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org> Closes apache#1633 from MuktiKrishnan/ZOOKEEPER-4230-master
…executing commands -waitforconnection option will make zk client wait for -timeout time to connect to zk server. timeout time is 30ms by default but can be specified explicitly for a session using -timeout option in command line. Author: Mukti <muktikrishnan94@gmail.com> Reviewers: maoling <maoling@apache.org>, Mohammad Arshad <arshad@apache.org> Closes apache#1626 from MuktiKrishnan/ZOOKEEPER-1871-master and squashes the following commits: 2947514 [Mukti] ZOOKEEPER-1871: Removed statement which was re-creating zookeeper admin in ZooKeeperMain.java and added documentation for waitforconnection in zookeeperCLI.md and c475d46 [Mukti] ZOOKEEPER-1871: Add an option to zkCli to wailt for connection before executing commands
…d free port …d free port Author: Amichai Rothman <amichai@apache.org> Reviewers: Damien Diederen <dd@crosstwine.com>,Andor Molnar <andor@apache.org>,Christopher Tubbs <ctubbsii@apache.org>,Mohammad Arshad <arshad@apache.org> Closes apache#1599 from amichair/ZOOKEEPER-4205
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View detailed results in CodeScene
- Quality Gates: FAILED
- Issues Detected: (3)
- Issues Improved: (0)
- Affected Hotspots: (0) 🔥
- Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
Violations summary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
- Complex Method ZooKeeperMain.java: ZooKeeperMain.MyCommandOptions.parseOptions🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
- Complex Method ZooKeeperMain.java: ZooKeeperMain.MyCommandOptions.parseOptions🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: ZooKeeperMain.MyCommandOptions.parseOptions🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
- Complex Method ZooKeeperMain.java: ZooKeeperMain.MyCommandOptions.parseOptions🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method ZooKeeperMain.java: connectToZK🔥
- Complex Method ZooKeeperMain.java: ZooKeeperMain.MyCommandOptions.parseOptions🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
No description provided.