Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows build issue, changed to platform independent external parameter in rollup config file #406

Merged

Conversation

Spiral-Memory
Copy link
Contributor

Resolved build problem in windows environment by modifying the rollup configuration file to use a platform-independent external parameter.

Acceptance Criteria fulfillment

  • [✓] Identified the problem by debugging through the log file and confirmed it by replicating the issue in a dummy project with the same configuration.
  • [✓] Updated the external parameter passed via the bundle function in the rollup configuration file, making it platform-independent.
  • [✓] Referred to the issue link for details for the fix: Regex in external doesn't exclude local import rollup/rollup#3811
  • [✓] Performed comprehensive testing on both Windows and Linux environments to ensure that it functions correctly.

Fixes #405

Video/Screenshots

Verification of the build process on Linux:
https://github.com/RocketChat/EmbeddedChat/assets/78961432/717b61d1-2f2b-43f9-91fb-b8faa275dbd8

Building process on Windows for verification:
https://github.com/RocketChat/EmbeddedChat/assets/78961432/1631d5b9-bd74-4022-be83-bd46340561ca

Copy link
Member

@abhinavkrin abhinavkrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Spiral-Memory Looks good to me. Great Find.

@abhinavkrin abhinavkrin merged commit 210d164 into RocketChat:develop Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Embedded chat build fails on windows environment Regex in external doesn't exclude local import
2 participants