-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignoreWarnings not working on webpack 5 #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
A few considerations:
- technically this is a breaking change since the plugin will no longer work with webpack versions < 5, so we should bump the version to
3.0.0
- the failing test is due to changes in the
postcss-loader
config API, but after fixing this I found that the original test case is no longer valid for webpack 5 and the latest version ofautoprefixer
. I think it's best to remove theShould handle warning from child compiler
test case fromtests/test.spec.ts
, as well as any related files that are no longer needed for the test (tests/childWarning.js
,tests/test.css
). This means we can also remove the css loaders/plugins fromtests/webpack.config.ts
and package dependencies, too. - I know that
TSLint
is long deprecated, but I think it would be great to replace it with ESLint (or at least keep it around until we do).
Thanks again! 🙏
Let me get this fixed up. 🙏 |
@RoccoC let me know if that resolves all the issues. 🙏 |
bump ⬆️ |
There's an issue when running |
if tests need to pass before merging then a CI action should be added to enforce that. |
i cannot get the tests to run locally. they just sit there without doing anything.
|
I'll get these fixed up and merged. Thanks for your PR. |
Thanks for flagging this. Looks like TravisCI was no longer working. I went ahead and migrated to CircleCI. |
Thanks for the work here! Just to confirm - given the major version bump, does this drop support for Webpack 4 or still backwards compatible? |
if this PR isn't wanted im happy to maintain my own fork. 🙏
also im not 100% how to fix the error the tests are throwing. 🤔
if someone can point me in the right direction ill be happy to fix them up.
closes: #90 and #81