Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpacks's ignoreWarnings is not used #90

Closed
ImLunaHey opened this issue Oct 17, 2023 · 8 comments 路 Fixed by #91
Closed

webpacks's ignoreWarnings is not used #90

ImLunaHey opened this issue Oct 17, 2023 · 8 comments 路 Fixed by #91

Comments

@ImLunaHey
Copy link

I noticed I'm still getting notifications for warnings that're being filtered by webpack's ignoreWarnings field. 馃
@ImLunaHey ImLunaHey mentioned this issue Oct 17, 2023
Merged
@nolimitdev
Copy link

The same problem here :( Also webpack-build-notifier does not support messages filtering to omit it.

@RoccoC
Copy link
Owner

RoccoC commented May 16, 2024

There's an open PR to fix this, but IIRC tests are failing. Happy to merge it in once the issues there are fixed! 馃檹 cc: @ImLunaHey

@ImLunaHey
Copy link
Author

this has been working in production for a while now. which tests aren't passing?

RoccoC pushed a commit that referenced this issue May 27, 2024
@ImLunaHey
fix: ignoreWarnings not working on webpack 5 (#91)
fafc00f 
fix: #81 and #90
@RoccoC
Copy link
Owner

RoccoC commented May 27, 2024

Fixed in #91 and #92.

@RoccoC RoccoC closed this as completed May 27, 2024
@Drumstix42
Copy link

Drumstix42 commented May 29, 2024 •
edited

In my configuration, to use v3.0.0, I needed to update my import from this:

const WebpackBuildNotifierPlugin = require('webpack-build-notifier');

to:

const WebpackBuildNotifierPlugin = require('webpack-build-notifier').default

Is that expected?

@RoccoC
Copy link
Owner

RoccoC commented May 29, 2024

Is that expected?

No, it isn't. Looks like this is because of how tsup bundles commonjs. Let me get this fixed...

@RoccoC
Copy link
Owner

RoccoC commented May 29, 2024

@Drumstix42 , this is fixed in 3.1.0. Thanks for bringing it to my attention!

@nolimitdev
Copy link

Confirming that issue is fixed. Thanks all! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignoreWarnings not working on webpack 5 ImLunaHey/webpack-build-notifier
4 participants
@RoccoC @Drumstix42 @nolimitdev @ImLunaHey