Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split publish NPM hook into prepublishOnly and prepare #715

Merged
merged 1 commit into from Apr 18, 2024

Conversation

EzraBrooks
Copy link
Contributor

@EzraBrooks EzraBrooks commented Apr 17, 2024

Public API Changes

None.

Description

Closes #714. Currently, installing this package via Git triggers some unwanted lifecycle hooks. This makes npm or pnpm install roslib@github:RobotWebTools/roslibjs#develop work.

@EzraBrooks
Copy link
Contributor Author

@RamiCMT does installing this branch via NPM work for you? it seems to work for me via PNPM.

@RamiCMT
Copy link

RamiCMT commented Apr 17, 2024

@RamiCMT does installing this branch via NPM work for you? it seems to work for me via PNPM.

This is what I'm seeing:
image

I may need to update my import syntax, I will circle back if I can get that working...

@EzraBrooks
Copy link
Contributor Author

That output should work without the src directory; There's no reference to src in the package.json's entrypoints. Are you not able to require/import this into your application for some reason?

@RamiCMT
Copy link

RamiCMT commented Apr 17, 2024

That output should work without the src directory; There's no reference to src in the package.json's entrypoints. Are you not able to require/import this into your application for some reason?

The proposed changes work! :)

I had to update some of my imports - seems like 'ServiceRequest' and 'Message' objects are no longer required

Thanks for the help!!

@EzraBrooks
Copy link
Contributor Author

Correct, we removed those interstitial types since they were just syntactic sugar around user-provided types and made it hard to implement TypeScript generics for the services, topics, etc.

Glad I could help!

@EzraBrooks EzraBrooks marked this pull request as ready for review April 17, 2024 18:14
@MatthijsBurgh
Copy link
Contributor

MatthijsBurgh commented Apr 18, 2024

@EzraBrooks what is the new release procedure?

update: The npm docs from #714 explained these changes.

@EzraBrooks EzraBrooks merged commit c7e340a into develop Apr 18, 2024
4 checks passed
@EzraBrooks EzraBrooks deleted the update-lifecycle-hooks branch April 18, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop branch doesn't work with npm - React
3 participants