121 use cypress best practises #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMeow
changed the title
RobinMeow
deleted the
121-replace-deletetestuser-at-end-of-tests-with-db-reset-before-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not use deleteTestUser at end of tests to clean up state (it should also not use the ui with cy.)
use cy.task('db:reset') to clean up state before tests when required
do not use createTestUser before tests to login (its using the UI as well, which should not be)
use minimal login implementation as command (using fetch and storing the response (access token) into localStorage
known issue at Cypress localhost URL not accessible after cy.request on server cypress-io/cypress#25397 (comment)
workaround as descibred in the cypress comment. (triggering a fetch to the spa, before all tests run)