Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings UseUriTypeForUriFormattedStrings #1567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -52,6 +52,8 @@ public CSharpGeneratorSettings()
InlineNamedArrays = false;
InlineNamedDictionaries = false;
InlineNamedTuples = true;

UseUriTypeForUriFormattedStrings = true;
}

/// <summary>Gets or sets the .NET namespace of the generated types (default: MyNamespace).</summary>
Expand Down Expand Up @@ -147,5 +149,8 @@ public CSharpGeneratorSettings()

/// <summary>Generate C# 9.0 record types instead of record-like classes.</summary>
public bool GenerateNativeRecords { get; set; }

/// <summary>Indicate if System.Uri should be used for strings with format uri (default: true)</summary>
public bool UseUriTypeForUriFormattedStrings { get; set; }
}
}
Expand Up @@ -182,7 +182,7 @@ private string ResolveString(JsonSchema schema, bool isNullable, string typeName

var nullableReferenceType = Settings.GenerateNullableReferenceTypes && isNullable ? "?" : string.Empty;

if (schema.Format == JsonFormatStrings.Uri)
if (schema.Format == JsonFormatStrings.Uri && Settings.UseUriTypeForUriFormattedStrings)
{
return "System.Uri" + nullableReferenceType;
}
Expand Down