Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root element of external schema ref files cannot be same name as any property of JsonSchema #1336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimfrederic
Copy link

No solution, just a failing test case to reproduce the problem.

@RicoSuter
Copy link
Owner

RicoSuter commented Mar 5, 2021

schema_named_title.yaml is not a valid JSON Schema...
Is this even supposed to work (ie. should this be allowed)?

@jimfrederic
Copy link
Author

schema_named_title.yaml is not a valid JSON Schema...
Is this even supposed to work (ie. should this be allowed)?

The example is contrived, admittedly, cut down from a real-world OpenApi document to minimize it. So take a similar example: If you modify an existing test, changing myBool to Title here in collection.json and here in schema_with_collection_reference.json, then the test case When_schema_references_collection_in_definitions_it_works throws the same exception while parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants