Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup guide for serving locally #6

Merged
merged 3 commits into from Jun 18, 2021
Merged

Add setup guide for serving locally #6

merged 3 commits into from Jun 18, 2021

Conversation

jonmaddock
Copy link
Contributor

Closes #4. Adding a guide to setup for serving the site locally for previewing changes.

@jonmaddock jonmaddock requested a review from jholloc April 12, 2021 15:23
@jonmaddock jonmaddock self-assigned this Apr 12, 2021
@jonmaddock
Copy link
Contributor Author

@jholloc can you let me know if these steps work for you?

@jonmaddock
Copy link
Contributor Author

@jholloc could you review this please?

@jholloc
Copy link
Contributor

jholloc commented Apr 22, 2021

@jholloc could you review this please?

We need to add "webrick" to the Gemfile to make it work on newer versions of ruby, otherwise it worked fine.

@jonmaddock
Copy link
Contributor Author

@jholloc I'm guessing this is your problem: github/pages-gem#752. One of the solutions suggested is to add:

ruby versions["ruby"]

to the Gemfile; apparently this tells bundler to use the ruby version used by github-pages. This might be a more complete solution than the webrick one, if anything else breaks again, or until this problem is fixed by Github Pages. Can you try this out and add the line to the Gemfile if it works?

@jonmaddock
Copy link
Contributor Author

Also, was jekyll installed using the steps in these instructions (I think bundle install installs it as a dependency), or did you have to install it separately? I should add it as a step if not.

@jonmaddock
Copy link
Contributor Author

Also, was jekyll installed using the steps in these instructions (I think bundle install installs it as a dependency), or did you have to install it separately? I should add it as a step if not.

jekyll was installed by bundler as a dependency, so it isn't required as a separate step.

@jonmaddock jonmaddock removed the request for review from jholloc June 18, 2021 14:50
Required in later Ruby versions
@jonmaddock
Copy link
Contributor Author

jonmaddock commented Jun 18, 2021

Added webrick dependency for later Ruby versions.

Have run through instructions from scratch and they appear to work fine.

@jonmaddock jonmaddock merged commit 51cf160 into master Jun 18, 2021
@jonmaddock jonmaddock deleted the add-setup-guide branch June 18, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setup guide
2 participants