Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Description to the arguments and fields #149

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

brcase-ut
Copy link
Contributor

@brcase-ut brcase-ut commented Sep 12, 2023

Description, motivation and context

Adding Description to the arguments and fields

Some CI tools are set to require descriptions on fields and arguments

Related issue(s) or PR(s)

#148

Some CI tools are set to require descriptions on fields and arguments

RenoFi#148

Signed-off-by: Brandon Case <brcase@usertesting.com>
@knapo
Copy link
Member

knapo commented Sep 13, 2023

Thanks!

Comment on lines 17 to 18
field :collection, [source_type], null: false, describe: "A collection of paginated #{graphql_name}"
field :metadata, metadata_type, null: false, describe: "Pagination Metadata for navigating the Pagination"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raises:

ArgumentError:
  unknown keyword: :describe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, i updated it to be description

Signed-off-by: Brandon Case <brcase@usertesting.com>
@dpena-ut
Copy link
Contributor

@knapo Thanks for the review. I see you added the automerge label and I found your workflow that is supposed to merge it. Looks like that failed for some reason although it isn't clear to me why.

2023-09-15T06:02:11.048Z INFO  PR is probably ready: mergeable_state: unstable
2023-09-15T06:02:11.328Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:11.328Z INFO  Retrying after 5000 ms ... (1/6)
2023-09-15T06:02:17.117Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:17.117Z INFO  Retrying after 5000 ms ... (2/6)
2023-09-15T06:02:22.797Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:22.797Z INFO  Retrying after 5000 ms ... (3/6)
2023-09-15T06:02:28.478Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:28.479Z INFO  Retrying after 5000 ms ... (4/6)
2023-09-15T06:02:34.161Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:34.161Z INFO  Retrying after 5000 ms ... (5/6)
2023-09-15T06:02:39.886Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:39.886Z INFO  Retrying after 5000 ms ... (6/6)
2023-09-15T06:02:45.592Z INFO  Failed to merge PR: Resource not accessible by integration
2023-09-15T06:02:45.592Z INFO  PR not ready to be merged after 6 tries
2023-09-15T06:02:45.592Z INFO  Action result: { mergeResult: 'merge_failed', pullRequestNumber: 149 }

@knapo knapo merged commit 467cfe5 into RenoFi:main Sep 15, 2023
7 checks passed
@dpena-ut
Copy link
Contributor

The workflow seems to have a problem with other folks as well: pascalgn/automerge-action#236 Thanks for merging manually.

@knapo
Copy link
Member

knapo commented Sep 15, 2023

Thanks, I'll look into automerge issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants