Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add eslint-plugin-import and extensions to import paths #376

Merged
merged 9 commits into from Jun 27, 2022

Conversation

wsuwt
Copy link
Collaborator

@wsuwt wsuwt commented Jun 23, 2022

Description

Adding eslint-plugin-import plugin to enforce adding extension to all internal import paths.

@wsuwt wsuwt self-assigned this Jun 23, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 23, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 910a3e7
Status: ✅  Deploy successful!
Preview URL: https://da05b794.refinitiv-ui.pages.dev
Branch Preview URL: https://lint-import-plugin.refinitiv-ui.pages.dev

View logs

@wsuwt
Copy link
Collaborator Author

wsuwt commented Jun 23, 2022

cc. @goremikins @TremayneChrist

@wsuwt
Copy link
Collaborator Author

wsuwt commented Jun 24, 2022

Ok, type import should ignore extension rule by default, see import-js/eslint-plugin-import#2270. However, export type is not ignored which is a bug and its PR in in progress import-js/eslint-plugin-import#2436. I still think this plugin would be beneficial to our workflow. There are more rules that we can enforce on imports and exports.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wsuwt wsuwt merged commit 67fd03f into v6 Jun 27, 2022
@wsuwt wsuwt deleted the lint-import-plugin branch June 27, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants