Skip to content

Commit

Permalink
docs: fix wrong phrasebook locale import paths (#379)
Browse files Browse the repository at this point in the history
  • Loading branch information
wsuwt committed Jun 27, 2022
1 parent 485221e commit e38f9a5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions documents/src/pages/build-app/internationalization.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ The simplest way is to include translations in a bundle, for instance:
// # translations.js

// ef-tree-select, Japanese and German locales
import '@refinitiv-ui/phrasebook/locale/ja/tree-select';
import '@refinitiv-ui/phrasebook/locale/de/tree-select';
import '@refinitiv-ui/phrasebook/locale/ja/tree-select.js';
import '@refinitiv-ui/phrasebook/locale/de/tree-select.js';

// ef-pagination, Simplified and Traditional Chinese locales
import '@refinitiv-ui/phrasebook/locale/zh/pagination';
import '@refinitiv-ui/phrasebook/locale/zh-hant/pagination';
import '@refinitiv-ui/phrasebook/locale/zh/pagination.js';
import '@refinitiv-ui/phrasebook/locale/zh-hant/pagination.js';
```

Including translations in such a way will increase the bundle size, but has the benefit that translations are available immediately on application load.
Expand All @@ -83,7 +83,7 @@ App.Settings.Language.read(value => {
const locale = supportedLocales(['ja', 'de'], [value])[0];
if (locale) {
// use dynamic import. Element will update itself once locale is loaded
import(`@refinitiv-ui/phrasebook/locale/${locale}/pagination`);
import(`@refinitiv-ui/phrasebook/locale/${locale}/pagination.js`);
}
});
```
Expand Down
2 changes: 1 addition & 1 deletion packages/translate/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
} from '@refinitiv-ui/translate';

// import default English language
import '@refinitiv-ui/phrasebook/locale/en/my-translate-element';
import '@refinitiv-ui/phrasebook/locale/en/my-translate-element.js';

@customElement('my-translate-element')
export class MyTranslateElement extends BasicElement {
Expand Down

0 comments on commit e38f9a5

Please sign in to comment.