Adopt black in pre-commit #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update using black for formatting python code, automatically apply change in the pre-commit hook. More info about black: https://black.readthedocs.io/en/stable/ Signed-off-by: Wayne Sun <gsun@redhat.com>
|
pre-commit have dropped 3.6 support |
Signed-off-by: Wayne Sun <gsun@redhat.com>
Python 3.6 will fail with pre-commit setup:
Complete output (6 lines):
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/runner/.cache/pre-commit/repozbn0y53a/setup.py", line 1
from __future__ import annotations
^
SyntaxError: future feature annotations is not defined
The pre-commit project has dropped support on 3.6:
pre-commit/pre-commit#2215
Signed-off-by: Wayne Sun <gsun@redhat.com>
waynesun09
force-pushed
the
pre_commit_black
branch
from
8f0b3ed
to
f56d8f2
Compare
leelavg
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update using black for formatting python code, automatically apply change in the pre-commit hook.
More info about black:
https://black.readthedocs.io/en/stable/
Signed-off-by: Wayne Sun gsun@redhat.com