Feat/answer to comments #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comments parent uri as keyword argument to `create_comment` - check if parent uri is an existing comment of this workitem - this enables commenting existing comments - replace ceateComment with addComment as former is deprecated
|
PS: CI Pipeline is failing due to psf/black#4175 :( |
|
The update lgtm. I saw the createComment API is marked as Deprecated by addComment, so this change is necessary and we could keep the create_comment function name for backward compatibility for our users. For the Black and reorder incompatible issue, could you revert the change with pre-commit component changes until there is a solution for that, thanks. |
- roll back necessary due to psf/black#4175
AlthausKonstantin
force-pushed
the
feat/answer_to_comments
branch
from
6ee96d7
to
e36b40f
Compare
waynesun09
reviewed
Mar 5, 2024
src/pylero/work_item.py
Outdated
| @@ -709,15 +711,23 @@ def create_attachment(self, path, title): | |||
| self.uri, filename, title, data | |||
| ) | |||
|
|
|||
| def create_comment(self, content): | |||
| """method create_comment adds a comment to the current _WorkItem | |||
| def create_comment(self, title, content, parent_uri=None): | |||
There was a problem hiding this comment.
Need switch title and content position to make it backward compatible, test failed with:
src/unit_tests/work_item_test.py::WorkItemTest::test_009_create_comment - TypeError: _WorkItem.create_comment() missing 1 required positional argument: 'content'
|
Thanks, lgtm and test also pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for #171.