Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement forgotten meta_attr quotes migration #523

Merged
merged 1 commit into from
May 21, 2024

Conversation

osoukup
Copy link
Contributor

@osoukup osoukup commented May 16, 2024

to make the existing meta_attr compatible with json.loads

(on the production I already performed the necessary migrations by hand so this is not urgent)

@osoukup osoukup added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label May 16, 2024
@osoukup osoukup requested a review from a team May 16, 2024 15:30
@osoukup osoukup self-assigned this May 16, 2024
Copy link
Contributor

@jsvob jsvob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single bug, LGTM.

osidb/migrations/0128_fix_meta_attr_quotes.py Outdated Show resolved Hide resolved
to make the existing meta_attr compatible with json.loads
@osoukup osoukup requested a review from jsvob May 21, 2024 06:05
@osoukup
Copy link
Contributor Author

osoukup commented May 21, 2024

@jsvob please re-review

@osoukup osoukup added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 33d8557 May 21, 2024
10 checks passed
@osoukup osoukup deleted the migrate-meta-attr-quotes branch May 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants