Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by null or empty CVE IDs in the API #522

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

dmonzonis
Copy link
Contributor

With this commit, there is now the possibility to filter, at the API level, for null or empty CVE IDs.

To do this, one may use the query parameter cve_id__isempty and set it to 1 (show only flaws with null or empty CVE IDs) or 0 (show flaws with CVE IDs that are neither null nor empty).

The change has been done in a way that it could be reused by other nullable string fields in the future, if needed.

Closes OSIDB-2625.

@dmonzonis dmonzonis requested a review from a team May 16, 2024 11:28
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

Copy link
Contributor

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

With this commit, there is now the possibility to filter, at the API
level, for null or empty CVE IDs.

To do this, one may use the query parameter cve_id__isempty and set it
to 1 (show only flaws with null or empty CVE IDs) or 0 (show flaws with
CVE IDs that are neither null nor empty).

The change has been done in a way that it could be reused by other
nullable string fields in the future, if needed.

Closes OSIDB-2625.
@dmonzonis dmonzonis enabled auto-merge May 21, 2024 09:31
@dmonzonis dmonzonis added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 020ac25 May 21, 2024
11 checks passed
@dmonzonis dmonzonis deleted the search-empty-cve branch May 21, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants