Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable creation of Jira tasks for collector flaws #520

Merged
merged 2 commits into from
May 22, 2024
Merged

Enable creation of Jira tasks for collector flaws #520

merged 2 commits into from
May 22, 2024

Conversation

jobselko
Copy link
Contributor

@jobselko jobselko commented May 15, 2024 •
edited

This PR fixes and enables the creation of associated Jira tasks for flaws created by NVD and OSV collectors.

Closes OSIDB-2649

@jobselko jobselko self-assigned this May 15, 2024
@jobselko jobselko force-pushed the flawdraft_jira branch 2 times, most recently from 07fd716 to 1777668 Compare May 15, 2024 14:49
@jobselko jobselko added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label May 15, 2024
@jobselko jobselko force-pushed the flawdraft_jira branch 6 times, most recently from 8bbe46e to fd779df Compare May 20, 2024 13:37
@jobselko jobselko marked this pull request as ready for review May 20, 2024 13:47
@jobselko jobselko requested review from a team and costaconrado May 20, 2024 13:47
@jobselko jobselko removed the technical For PRs that introduce changes not worthy of a CHANGELOG entry label May 20, 2024
@jobselko jobselko force-pushed the flawdraft_jira branch 3 times, most recently from cbc459c to dd4da99 Compare May 21, 2024 08:23
osoukup
osoukup approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jobselko jobselko marked this pull request as draft May 21, 2024 08:36
@jobselko jobselko force-pushed the flawdraft_jira branch 2 times, most recently from df253ac to 39b212b Compare May 21, 2024 11:02
@jobselko jobselko marked this pull request as ready for review May 21, 2024 11:13
costaconrado
costaconrado approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@costaconrado costaconrado left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a comment / question about the JIRA_AUTH_TOKEN variable being patched.

@jobselko jobselko added this pull request to the merge queue May 21, 2024
@jobselko jobselko removed this pull request from the merge queue due to a manual request May 21, 2024
@jobselko jobselko force-pushed the flawdraft_jira branch 3 times, most recently from 40e0820 to 46070f8 Compare May 21, 2024 13:28
@jobselko jobselko mentioned this pull request May 21, 2024
Merged
@jobselko jobselko force-pushed the flawdraft_jira branch 4 times, most recently from 8e2ca1c to ded6998 Compare May 22, 2024 19:19
@jobselko jobselko enabled auto-merge May 22, 2024 19:33
@jobselko jobselko added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 8770bf7 May 22, 2024
10 checks passed
@jobselko jobselko deleted the flawdraft_jira branch May 22, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costaconrado costaconrado costaconrado approved these changes

@osoukup osoukup osoukup approved these changes

Assignees

@jobselko jobselko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jobselko @costaconrado @osoukup